Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 29 Jun 2012 00:19:44 +0000 (UTC)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1934537280.69888.1340929184167.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1627914245.8618.1333486943204.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3190) Simple refactors in existing NN code
 to assist QuorumJournalManager extension
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403616#comment-13403616 ] 

Suresh Srinivas commented on HDFS-3190:
---------------------------------------

Nice refactoring. +1 for the patch with some minor comments:
# Some lines are over 80 chars. 
# StorageErrorReporter.java
#* StorageErrorReporter javadoc - can you please add link to JournalManager. I am not very clear on what you mean by "central manager of storage directory state".
#* Also can you please add javadoc description to the methods
# PersistentLong - PersistentLongFile or AtomicLongFile better name?

                
> Simple refactors in existing NN code to assist QuorumJournalManager extension
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-3190
>                 URL: https://issues.apache.org/jira/browse/HDFS-3190
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt
>
>
> This JIRA is for some simple refactors in the NN:
> - refactor the code which writes the seen_txid file in NNStorage into a new "LongContainingFile" utility class. This is useful for the JournalNode to atomically/durably record its last promised epoch
> - refactor the interface from FileJournalManager back to StorageDirectory to use a StorageErrorReport interface. This allows FileJournalManager to be used in isolation of a full StorageDirectory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira