Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 16 Jun 2012 22:21:42 +0000 (UTC)
From: "Matthew Jacobs (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1168481059.22146.1339885302839.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <956451793.17388.1337386082503.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-3446) HostsFileReader silently ignores bad
 includes/excludes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Jacobs updated HDFS-3446:
---------------------------------

    Attachment: hdfs-3446.txt

New version of the patch addresses Todd's comments. The checks have been removed from the setIncludesFile/setExcludesFile.
                
> HostsFileReader silently ignores bad includes/excludes
> ------------------------------------------------------
>
>                 Key: HDFS-3446
>                 URL: https://issues.apache.org/jira/browse/HDFS-3446
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Matthew Jacobs
>            Assignee: Matthew Jacobs
>         Attachments: hdfs-3446.txt, hdfs-3446.txt
>
>
> The HostsFileReader silently fails if the includes or excludes files do
> not exist or are not readable. The current behavior is to overwrite the
> existing set of hosts or excluded hosts, regardless of whether or not
> the includes/excludes file exists.
> This behavior was introduced in HADOOP-5643 to support updating the job
> tracker's node lists. The HostsFileReader is no longer used by the job
> tracker. If this behavior was intentional, it no longer seems necessary
> for any reason. The HostsFileReader is still used by NodeListManager as
> well as the DatanodeManager, and in both cases, throwing an exception
> when the include/exclude files aren't found/readable is desirable.
> We should validate the given includes and excludes files before using
> them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira