Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 26 Jun 2012 18:41:44 +0000 (UTC)
From: "Alejandro Abdelnur (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1066875705.57737.1340736104607.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <254714877.22512.1338481344608.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3481) Refactor HttpFS handling of JAX-RS
 query string parameters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401594#comment-13401594 ] 

Alejandro Abdelnur commented on HDFS-3481:
------------------------------------------

On the warning:

Offending source:

{code}
...
  private static final Map<Enum, Class<Param<?>>[]> PARAMS_DEF =
    new HashMap<Enum, Class<Param<?>>[]>();

  static {
    PARAMS_DEF.put(Operation.OPEN,
      new Class[]{DoAsParam.class, OffsetParam.class, LenParam.class});
...
{code}

{code}
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSParametersProvider.java:[48,6] [unchecked] unchecked conversion
found   : java.lang.Class[]
required: java.lang.Class<org.apache.hadoop.lib.wsrs.Param<?>>[]
{code}

Regarding the duplication of Parameter class, I think the reason for the duplication is that Webhdfs is tightly coupled with HDFS code (within the same maven module) while HttpFS is decoupled and could (in theory) be used without HDFS itself in the classpath. As part of HDFS-2645 all this dup code would go away.

                
> Refactor HttpFS handling of JAX-RS query string parameters
> ----------------------------------------------------------
>
>                 Key: HDFS-3481
>                 URL: https://issues.apache.org/jira/browse/HDFS-3481
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.1-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.1-alpha
>
>         Attachments: HDFS-3481.patch, HDFS-3481.patch, HDFS-3481.patch
>
>
> Explicit parameters in the HttpFSServer became quite messy as they are the union of all possible parameters for all operations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira