Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 816D8D45A for ; Thu, 28 Jun 2012 23:01:46 +0000 (UTC) Received: (qmail 7963 invoked by uid 500); 28 Jun 2012 23:01:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 7908 invoked by uid 500); 28 Jun 2012 23:01:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 7798 invoked by uid 99); 28 Jun 2012 23:01:46 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jun 2012 23:01:46 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id A0CE114284F for ; Thu, 28 Jun 2012 23:01:45 +0000 (UTC) Date: Thu, 28 Jun 2012 23:01:45 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1020620785.69512.1340924505660.JavaMail.jiratomcat@issues-vm> In-Reply-To: <553465024.41682.1338934584773.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (HDFS-3510) Improve FSEditLog pre-allocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HDFS-3510: ---------------------------------- Resolution: Fixed Fix Version/s: (was: 2.0.1-alpha) (was: 1.0.0) 3.0.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1 for the patch. I committed it to trunk. Thank you Colin. > Improve FSEditLog pre-allocation > -------------------------------- > > Key: HDFS-3510 > URL: https://issues.apache.org/jira/browse/HDFS-3510 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 1.0.0, 2.0.0-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Fix For: 3.0.0 > > Attachments: HDFS-3510-b1.001.patch, HDFS-3510-b1.002.patch, HDFS-3510.001.patch, HDFS-3510.003.patch, HDFS-3510.004.patch, HDFS-3510.004.patch, HDFS-3510.006.patch, HDFS-3510.007.patch, HDFS-3510.008.patch, HDFS-3510.009.patch, HDFS-3510.010.patch, HDFS-3510.011.patch > > > It is good to avoid running out of space in the middle of writing a batch of edits, because when it happens, we often get partial edits at the end of the log. > Edit log preallocation can solve this problem (see HADOOP-2330 for a full description of edit log preallocation). > The current pre-allocation code was introduced for performance reasons, not for preventing partial edits. As a consequence, we sometimes do a write without using pre-allocation. We should change the pre-allocation code so that it always preallocates at least enough space before writing out the edits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira