hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3490) DN WebHDFS methods throw NPE if Namenode RPC address param not specified
Date Wed, 06 Jun 2012 02:58:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289916#comment-13289916
] 

Hadoop QA commented on HDFS-3490:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531052/h3490_20120605.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
                  org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
                  org.apache.hadoop.hdfs.TestDistributedFileSystem
                  org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
                  org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2602//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2602//console

This message is automatically generated.
                
> DN WebHDFS methods throw NPE if Namenode RPC address param not specified
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3490
>                 URL: https://issues.apache.org/jira/browse/HDFS-3490
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h3490_20120605.patch
>
>
> Currently, there is no validation done on the NamenodeRpcAddressParam. If it is not passed
to the datanode webhdfs methods, an NPE will be generated trying to use it. We should instead
have some kind of validation on the parameter and throw a more appropriate error message when
it is missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message