hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3502) Change INodeFile and INodeFileUnderConstruction to package private
Date Mon, 11 Jun 2012 18:30:44 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo (Nicholas), SZE updated HDFS-3502:
-----------------------------------------

    Attachment: h3502_20120611.patch

John, good point.  I added @InterfaceAudience.Private in the following path.

h3502_20120611.patch

For BlockInfo.EMPTY_ARRAY, it is used in INodeFileUnderConstruction and FSDirectory.  The
original code passes length 0 and create new BlockInfo[0].  It is a small optimization to
avoid creating empty array since empty arrays are immutable.
                
> Change INodeFile and INodeFileUnderConstruction to package private
> ------------------------------------------------------------------
>
>                 Key: HDFS-3502
>                 URL: https://issues.apache.org/jira/browse/HDFS-3502
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h3502_20120608.patch, h3502_20120611.patch
>
>
> We already have BlockCollection and MutableBlockCollection interfaces so that INodeFile
and INodeFileUnderConstruction can be changed to package private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message