hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3498) Make Replica Removal Policy pluggable and ReplicaPlacementPolicyDefault extensible for reusing code in subclass
Date Tue, 26 Jun 2012 03:26:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401138#comment-13401138
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3498:
----------------------------------------------

+1 The v5 patch looks good.  Since the changes are minor, I will commit it without waiting
for Jenkins again.
                
> Make Replica Removal Policy pluggable and ReplicaPlacementPolicyDefault extensible for
reusing code in subclass
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3498
>                 URL: https://issues.apache.org/jira/browse/HDFS-3498
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3498-v2.patch, HDFS-3498-v3.patch, HDFS-3498-v4.patch, HDFS-3498-v5.patch,
HDFS-3498.patch, Hadoop-8471-BlockPlacementDefault-extensible.patch
>
>
> ReplicaPlacementPolicy is already a pluggable component in Hadoop. However, the Replica
Removal Policy is still nested in BlockManager that need to be separated out into a ReplicaPlacementPolicy
then can be override later. Also it looks like hadoop unit test lack the testing on replica
removal policy, so we add it here.
> On the other hand, as a implementation of ReplicaPlacementPolicy, ReplicaPlacementDefault
still show lots of generic for other topology cases like: virtualization, and we want to make
code in ReplicaPlacementPolicyDefault can be reused as much as possible so a few of its methods
were changed from private to protected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message