hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3485) DataTransferThrottler will over-throttle when currentTimeMillis jumps
Date Fri, 01 Jun 2012 02:55:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287111#comment-13287111

Hadoop QA commented on HDFS-3485:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2563//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2563//console

This message is automatically generated.
> DataTransferThrottler will over-throttle when currentTimeMillis jumps
> ---------------------------------------------------------------------
>                 Key: HDFS-3485
>                 URL: https://issues.apache.org/jira/browse/HDFS-3485
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>            Priority: Minor
>         Attachments: hdfs-3485.patch
> When the system clock is set backwards, DataTransferThrottler will simply pause until
the clock reaches the end of the previously calculated transfer period:
> {code}
>     this.curPeriodStart = System.currentTimeMillis();
> ...
>     while (curReserve <= 0) {
>       long now = System.currentTimeMillis();
>       long curPeriodEnd = curPeriodStart + period;
>       if ( now < curPeriodEnd ) {
>         try {
>           wait( curPeriodEnd - now );
> {code}
> Instead of using currentTimeMillis() which is affected by system-clock-changes, this
code should use nanoTime which ticks forward monotonically.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message