hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-3521) Allow namenode to tolerate edit log corruption
Date Thu, 14 Jun 2012 23:20:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295305#comment-13295305
] 

Suresh Srinivas edited comment on HDFS-3521 at 6/14/12 11:19 PM:
-----------------------------------------------------------------

bq. Given that, I do think we should revert this commit until everyone's satisfied with the
changes it makes.
I am not sure if that is necessary. I have closely worked with Nicholas on this and we tested
this quite heavily. Hence +1 from my side.

If there are valid concerns about any bugs in the functionality, lets open another jira; 
I think this functionality is very useful. 

bq. I find the option to stop reading exceptionally helpful
The patch adds an option to turn off the functionality for this reason. Does that not work
for you?
                
      was (Author: sureshms):
    bq. Given that, I do think we should revert this commit until everyone's satisfied with
the changes it makes.
I am not sure if that is necessary. I have closely worked with Nicholas on this and we tested
this quite heavily. Hence +1 from my side.

If there are valid concerns, about any bug in the functionality, lets open another jira, because
I think this functionality is very useful. 

bq. I find the option to stop reading exceptionally helpful
The patch adds an option to turn off the functionality, for this reason. Does that not work
for you?
                  
> Allow namenode to tolerate edit log corruption
> ----------------------------------------------
>
>                 Key: HDFS-3521
>                 URL: https://issues.apache.org/jira/browse/HDFS-3521
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 1.2.0
>
>         Attachments: h3521_20120610_b-1.patch, h3521_20120611_b-1.0.patch, h3521_20120611_b-1.patch
>
>
> HDFS-3479 adds checking for edit log corruption. It uses a fixed UNCHECKED_REGION_LENGTH
(=PREALLOCATION_LENGTH) so that the bytes at the end within the length is not checked.  Instead
of not checking the bytes, we should check everything and allow toleration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message