hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2988) Improve error message when storage directory lock fails
Date Tue, 26 Jun 2012 03:08:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401131#comment-13401131
] 

Hadoop QA commented on HDFS-2988:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533385/HDFS-2988.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2697//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2697//console

This message is automatically generated.
                
> Improve error message when storage directory lock fails
> -------------------------------------------------------
>
>                 Key: HDFS-2988
>                 URL: https://issues.apache.org/jira/browse/HDFS-2988
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Todd Lipcon
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-2988.patch, HDFS-2988.patch, HDFS-2988.patch
>
>
> Currently, the error message is fairly opaque to a non-developer ("Cannot lock storage"
or something). Instead, we should have some improvments:
> - when we create the in_use.lock file, we should write the hostname/PID that locked the
file
> - if the lock fails, and in_use.lock exists, the error message should say something like
"It appears that another namenode (pid 23423 on host foo.example.com) has already locked the
storage directory."
> - if the lock fails, and no lock file exists, the error message should say something
like "if this storage directory is mounted via NFS, ensure that the appropriate nfs lock services
are running."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message