Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 598B39FA7 for ; Sat, 19 May 2012 00:08:24 +0000 (UTC) Received: (qmail 37512 invoked by uid 500); 19 May 2012 00:08:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 37443 invoked by uid 500); 19 May 2012 00:08:23 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37187 invoked by uid 99); 19 May 2012 00:08:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 May 2012 00:08:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 May 2012 00:08:22 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7A91BB14C for ; Sat, 19 May 2012 00:08:02 +0000 (UTC) Date: Sat, 19 May 2012 00:08:02 +0000 (UTC) From: "Matthew Jacobs (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <956451793.17388.1337386082503.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (HDFS-3446) HostsFileReader silently ignores bad includes/excludes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Matthew Jacobs created HDFS-3446: ------------------------------------ Summary: HostsFileReader silently ignores bad includes/excludes Key: HDFS-3446 URL: https://issues.apache.org/jira/browse/HDFS-3446 Project: Hadoop HDFS Issue Type: Bug Components: name-node Affects Versions: 1.0.0, 2.0.0 Reporter: Matthew Jacobs Assignee: Matthew Jacobs The HostsFileReader silently fails if the includes or excludes files do not exist or are not readable. The current behavior is to overwrite the existing set of hosts or excluded hosts, regardless of whether or not the includes/excludes file exists. This behavior was introduced in HADOOP-5643 to support updating the job tracker's node lists. The HostsFileReader is no longer used by the job tracker. If this behavior was intentional, it no longer seems necessary for any reason. The HostsFileReader is still used by NodeListManager as well as the DatanodeManager, and in both cases, throwing an exception when the include/exclude files aren't found/readable is desirable. We should validate the given includes and excludes files before using them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira