Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 4 May 2012 19:16:50 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <305928179.28458.1336159010408.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <912985102.6489.1334852560628.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3303) RemoteEditLogManifest doesn't need
 to implements Writable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268636#comment-13268636 ] 

Hadoop QA commented on HDFS-3303:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525655/HDFS-3303.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//console

This message is automatically generated.
                
> RemoteEditLogManifest doesn't need to implements Writable
> ---------------------------------------------------------
>
>                 Key: HDFS-3303
>                 URL: https://issues.apache.org/jira/browse/HDFS-3303
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-3303.patch
>
>
> Since we are using protocol buffers, RemoteEditLogManifest doesn't need to implements Writable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira