Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 30 May 2012 12:10:23 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <2101885799.15820.1338379823640.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <548093743.15549.1338373943419.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3474) Cleanup Exception handling in
 BookKeeper journal manager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285608#comment-13285608 ] 

Hadoop QA commented on HDFS-3474:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530188/HDFS-3474.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2543//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2543//console

This message is automatically generated.
                
> Cleanup Exception handling in BookKeeper journal manager
> --------------------------------------------------------
>
>                 Key: HDFS-3474
>                 URL: https://issues.apache.org/jira/browse/HDFS-3474
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3474.diff, HDFS-3474.diff
>
>
> There are a couple of instance of:
> {code}
> try {
>   ...
> } catch (Exception e) {
>   ...
> }
> {code}
> We should be catching the specific exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira