[ https://issues.apache.org/jira/browse/HDFS-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272524#comment-13272524 ] 

Aaron T. Myers commented on HDFS-3230:
--------------------------------------

+1, the patch looks good to me. Thanks a lot, Eli.
                
> Cleanup DatanodeID creation in the tests
> ----------------------------------------
>
>                 Key: HDFS-3230
>                 URL: https://issues.apache.org/jira/browse/HDFS-3230
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3230.txt, hdfs-3230.txt
>
>
> A lot of tests create dummy DatanodeIDs for testing, often use bogus values when creating the objects (eg hostname in the IP field), which they can get away with because the IDs aren't actually used. Let's add a test utility method for creating a DatanodeID for testing and use it throughout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira