hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3474) Cleanup Exception handling in BookKeeper journal manager
Date Wed, 30 May 2012 10:52:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285564#comment-13285564
] 

Uma Maheswara Rao G commented on HDFS-3474:
-------------------------------------------

Thanks a lot Ivan, for cleaning up the generic excetions.

small nit:
{code}
} catch (KeeperException ke) {
+      throw new IOException("Error in zookkeeper while creating ledger", ke);
+    } catch (InterruptedException ie) {
{code}
here zookkeeper --> zookeeper 

Other than this, patch looks great.
                
> Cleanup Exception handling in BookKeeper journal manager
> --------------------------------------------------------
>
>                 Key: HDFS-3474
>                 URL: https://issues.apache.org/jira/browse/HDFS-3474
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3474.diff
>
>
> There are a couple of instance of:
> {code}
> try {
>   ...
> } catch (Exception e) {
>   ...
> }
> {code}
> We should be catching the specific exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message