hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3134) Harden edit log loader against malformed or malicious input
Date Thu, 10 May 2012 23:17:55 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eli Collins updated HDFS-3134:
------------------------------

    Target Version/s:   (was: 2.0.0)
       Fix Version/s: 2.0.0
          Issue Type: Improvement  (was: Bug)
        Hadoop Flags: Reviewed
             Summary: Harden edit log loader against malformed or malicious input  (was: harden
edit log loader against malformed or malicious input)

I've committed this and merged to branch-2, thanks Colin!
                
> Harden edit log loader against malformed or malicious input
> -----------------------------------------------------------
>
>                 Key: HDFS-3134
>                 URL: https://issues.apache.org/jira/browse/HDFS-3134
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 2.0.0
>
>         Attachments: HDFS-3134.001.patch, HDFS-3134.002.patch, HDFS-3134.003.patch, HDFS-3134.004.patch,
HDFS-3134.005.patch, HDFS-3134.006.patch, HDFS-3134.007.patch, HDFS-3134.009.patch
>
>
> Currently, the edit log loader does not handle bad or malicious input sensibly.
> We can often cause OutOfMemory exceptions, null pointer exceptions, or other unchecked
exceptions to be thrown by feeding the edit log loader bad input.  In some environments, an
out of memory error can cause the JVM process to be terminated.
> It's clear that we want these exceptions to be thrown as IOException instead of as unchecked
exceptions.  We also want to avoid out of memory situations.
> The main task here is to put a sensible upper limit on the lengths of arrays and strings
we allocate on command.  The other task is to try to avoid creating unchecked exceptions (by
dereferencing potentially-NULL pointers, for example).  Instead, we should verify ahead of
time and give a more sensible error message that reflects the problem with the input.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message