hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3459) Fix the tests FSMainOperationsBaseTest.java and F ileContextMainOperationsBaseTest.java to avoid potential test failure
Date Tue, 29 May 2012 11:45:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284742#comment-13284742
] 

Hadoop QA commented on HDFS-3459:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528856/HDFS-3459.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2529//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2529//console

This message is automatically generated.
                
> Fix the tests FSMainOperationsBaseTest.java and F ileContextMainOperationsBaseTest.java
to avoid potential test failure
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3459
>                 URL: https://issues.apache.org/jira/browse/HDFS-3459
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 3.0.0
>            Reporter: Mariappan Asokan
>         Attachments: HDFS-3459.patch
>
>
> The above mentioned tests have a path filter to filter file names that contain either
the string "x" or "X".  The filter contains the following if statement:
> {code}
> if(file.getName().contains("x") || file.toString().contains("X"))
> {code}
> It should be corrected to:
> {code}
> if(file.getName().contains("x") || file.getName().contains("X"))
> {code}
> Note that toString() returns the full path name.  These tests will fail when a directory
name contains the string "X" and the base file name does not.  This was the case when we ran
the tests on our system.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message