hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3058) HA: Bring BookKeeperJournalManager up to date with HA changes
Date Sat, 12 May 2012 04:19:54 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273830#comment-13273830
] 

Uma Maheswara Rao G commented on HDFS-3058:
-------------------------------------------

Hi Ivan,  Thanks a lot for the patch. Few comments.

1)  Patch does not apply cleanly. many Hunk failure while applying patch.

{noformat}
Hunk #13 FAILED at 264.
Hunk #14 FAILED at 281.
Hunk #15 FAILED at 293.
Hunk #16 FAILED at 309.
Hunk #17 FAILED at 332.
Hunk #18 FAILED at 345.
Hunk #19 FAILED at 362.
Hunk #20 FAILED at 372.
Hunk #21 FAILED at 395.
{noformat}

Could you please regenerate on the correct trunk code base?

2) TestBookKeeperHACheckpoints.java: 

{code}
conf.set(DFSConfigKeys.DFS_NAMENODE_SHARED_EDITS_DIR_KEY,
+             BKJMUtil.createJournalURI("/checkpointing" + journalCount++)
+             .toString());
+    BKJMUtil.addJournalManagerDefinition(conf);
{code}

I can see setUpCluster code almost duplicates with TestStandbyCheckpoints. How about extracting
configuration setup alone to protected method in TestStandbyCheckpoints and override in TestBookKeeperHACheckpoints.
Set the above configurations and give the call to super.

3) {code}
+
+  @AfterClass
+  public static void shutdownBK() throws Exception {
+    bkutil.teardown();
+  }
{code}
Could you please add null condition for bkutil? also correct the bkutil->bkUtil

Not completed nmy review, will continue review...

                
> HA: Bring BookKeeperJournalManager up to date with HA changes
> -------------------------------------------------------------
>
>                 Key: HDFS-3058
>                 URL: https://issues.apache.org/jira/browse/HDFS-3058
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.24.0
>
>         Attachments: HDFS-3058.diff, HDFS-3058.diff
>
>
> There's a couple of TODO(HA) comments in the BookKeeperJournalManager code. This JIRA
is to address those.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message