hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3419) Cleanup LocatedBlock
Date Mon, 14 May 2012 16:31:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274718#comment-13274718
] 

Todd Lipcon commented on HDFS-3419:
-----------------------------------

{code}
     // create fake block of size 1 as a key
-    LocatedBlock key = new LocatedBlock();
+    LocatedBlock key = new LocatedBlock(
+        new ExtendedBlock(), new DatanodeInfo[0], 0L, false);
{code}

Strange that the comment size "size 1" but the block itself is size 0. Otherwise lgtm.
                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give
it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message