hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3427) TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
Date Wed, 16 May 2012 23:01:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277235#comment-13277235
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3427:
----------------------------------------------

If our code are so good that this is the only bad programming practice, it may worth to fix
it in order to make our code perfect.  Unfortunately, it is not the case.  We probably have
hundreds (if it is not thousands or more) of problems like this.  Why bother to fix this one?

IMHO, fixing trivial one-line changes in a test for the reason of good programming practice
is a kind of wasting resource.  It wastes contributors' time to check the issue and read the
emails.  It wastes users' time to read and understand the change (if it is committed) in CHANGES.txt
and release notes.  It also wastes our computation resource to record, track the change and
the issue (I wonder if we have to pay $100 for filing an issue from our pocket, would anyone
still file this?)  Something may appear to be free but there is indeed a cost behind.

BTW, I am not saying that not fixing this tiny trivial issue.  As in my previous comment,
we could remove the unused line whenever we change TestEditLogFileOutputStream or other related
code.

-----

@Todd, no, I am not suggesting this could be done without a JIRA.
                
> TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
> -------------------------------------------------------------
>
>                 Key: HDFS-3427
>                 URL: https://issues.apache.org/jira/browse/HDFS-3427
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Aaron T. Myers
>            Priority: Trivial
>              Labels: newbie
>
> The constant PREALLOCATION_LENGTH in TestEditLogFileOutputStream is no longer referenced
anywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message