hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "OZAWA Tsuyoshi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3427) TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
Date Mon, 21 May 2012 11:55:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280103#comment-13280103
] 

OZAWA Tsuyoshi commented on HDFS-3427:
--------------------------------------

IMHO, these 'trivial' problems should be ticketized and reviewed though it looks bother.
The reasons are as follows: 
1. The code changes without reviewing make the other developers confused who are making changes
the relevant codes.
2. These make it difficult to track changes.
3. These may cause enbugging through these looks trivial.
4. The range of 'trivial' deeply depends on the subjective view.
                
> TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
> -------------------------------------------------------------
>
>                 Key: HDFS-3427
>                 URL: https://issues.apache.org/jira/browse/HDFS-3427
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Aaron T. Myers
>            Priority: Trivial
>              Labels: newbie
>
> The constant PREALLOCATION_LENGTH in TestEditLogFileOutputStream is no longer referenced
anywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message