hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3388) GetJournalEditServlet should catch more exceptions, not just IOException
Date Thu, 10 May 2012 23:39:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272896#comment-13272896
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3388:
----------------------------------------------

- Since GetJournalEditServletFaultInjector is an inner class, let's simply call it FaultInjector.

- GetJournalEditServletFaultInjector.getInstance() is not used (and it should be static if
you want to use it.)

- change 
{code}
new String(path1.toString() + "/current")
{code}
to 
{code}
"path1 + "/current"
{code}

                
> GetJournalEditServlet should catch more exceptions, not just IOException
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3388
>                 URL: https://issues.apache.org/jira/browse/HDFS-3388
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-3388.HDFS-3092.patch, HDFS-3388.HDFS-3092.patch
>
>
> GetJournalEditServlet has the same problem as that of GetImageServlet (HDFS-3330). It
should be fixed in the same way. Also need to make CheckpointFaultInjector visible for journal
service tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message