hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3427) TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
Date Tue, 15 May 2012 22:15:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276275#comment-13276275
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3427:
----------------------------------------------

Removing an unused line from a test may be too minor for having a issue.  If we start doing
this kind of one-line changes, there could be hundreds of issues like this.  It could become
problems, e.g. harder to backtrack the commit log.

How about we close this issue as won't fix?  We could still remove the unused line whenever
we change TestEditLogFileOutputStream or other related code.
                
> TestEditLogFileOutputStream#PREALLOCATION_LENGTH is dead code
> -------------------------------------------------------------
>
>                 Key: HDFS-3427
>                 URL: https://issues.apache.org/jira/browse/HDFS-3427
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Aaron T. Myers
>            Priority: Trivial
>              Labels: newbie
>
> The constant PREALLOCATION_LENGTH in TestEditLogFileOutputStream is no longer referenced
anywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message