hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3391) TestPipelinesFailover#testLeaseRecoveryAfterFailover is failing
Date Thu, 17 May 2012 20:19:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278212#comment-13278212
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3391:
----------------------------------------------

The patch looks good.  Some comments:

- All calls of invalidateBlocks.contains(..) have matchGenStamp == true.  How about remove
matchGenStamp from the parameters?

- Remove the TODO below.
{code}
-    if(invalidateBlocks.contains(dn.getStorageID(), block)) {
+    if(invalidateBlocks.contains(dn.getStorageID(), block, true)) {
 /*  TODO: following assertion is incorrect, see HDFS-2668
 assert storedBlock.findDatanode(dn) < 0 : "Block " + block
         + " in recentInvalidatesSet should not appear in DN " + dn; */
{code}

- In LightWeightHashSet.getEqualElement(..), since the key will be cast to T, change the type
to T and remove @SuppressWarnings("unchecked").  Then, we need to cast the key to T in contains(..).
 Add @Override to contains(..).  Also, how about renaming getEqualElement to getElement?




                
> TestPipelinesFailover#testLeaseRecoveryAfterFailover is failing
> ---------------------------------------------------------------
>
>                 Key: HDFS-3391
>                 URL: https://issues.apache.org/jira/browse/HDFS-3391
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Arun C Murthy
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-3391.txt, hdfs-3391.txt
>
>
> Running org.apache.hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.208 sec <<<
FAILURE!
> --
> Running org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
> Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 81.195 sec <<<
FAILURE!
> --

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message