hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3357) DataXceiver reads from client socket with incorrect/no timeout
Date Fri, 04 May 2012 01:16:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268011#comment-13268011
] 

Hadoop QA commented on HDFS-3357:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525535/hdfs-3357.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2371//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2371//console

This message is automatically generated.
                
> DataXceiver reads from client socket with incorrect/no timeout
> --------------------------------------------------------------
>
>                 Key: HDFS-3357
>                 URL: https://issues.apache.org/jira/browse/HDFS-3357
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 1.0.2, 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-3357.txt, hdfs-3357.txt, hdfs-3357.txt
>
>
> In DataXceiver, we currently use Socket.setSoTimeout to try to manage the read timeout
when switching between reading the initial opCode, reading a keepalive opcode, and reading
the status after a successfully sent block. However, since all of these reads use the same
underlying DataInputStream, the change to the socket timeout isn't respected. Thus, they all
occur with whatever timeout is set on the socket at the time of DataXceiver construction.
In practice this turns out to be 0, which can cause infinitely hung xceivers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message