hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3412) Fix findbugs warnings in auto-HA branch
Date Sun, 13 May 2012 02:24:48 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Todd Lipcon updated HDFS-3412:

    Attachment: hdfs-3412.txt

- adds the generated protobufs to findbugs exclude
- adds some more synchronization in ZKFC to avoid "inconsistent synchronization" findbugs
- changes ZKFC to take its configuration and target in the constructor, rather than relying
on post-constructor "setConf()". This way these fields can be final, and we don't have to
synchronize to access them.

I ran the ZKFC tests under jcarder to verify this didn't introduce new potential deadlocks.
> Fix findbugs warnings in auto-HA branch
> ---------------------------------------
>                 Key: HDFS-3412
>                 URL: https://issues.apache.org/jira/browse/HDFS-3412
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: auto-failover, build
>    Affects Versions: Auto failover (HDFS-3042)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3412.txt
> A few minor findbugs warnings snuck in. Nothing looks like a real bug, but we should
fix before merging.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message