hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3371) EditLogFileInputStream: be more careful about closing streams when we're done with them.
Date Tue, 29 May 2012 21:40:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285157#comment-13285157
] 

Hadoop QA commented on HDFS-3371:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530087/HDFS-3371.002.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2535//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2535//console

This message is automatically generated.
                
> EditLogFileInputStream: be more careful about closing streams when we're done with them.
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-3371
>                 URL: https://issues.apache.org/jira/browse/HDFS-3371
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3371.001.patch, HDFS-3371.002.patch
>
>
> EditLogFileInputStream#EditLogFileInputStream should be more careful about closing streams
when there is an exception thrown.  Also, EditLogFileInputStream#close should close all of
the streams we opened in the constructor, not just one of them (although the file-backed one
is probably the most important).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message