hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3350) findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Date Thu, 03 May 2012 21:36:49 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267824#comment-13267824
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3350:
----------------------------------------------

Hi John, thanks for the review.

- The "synchronized" is useless and confusing since the fields are synchronized by the FSNamesystem
write lock.  See also HDFS-566.

- equals(..) and hashCode() should be changed together.  Since we disallow over ridding equals(..),
we do the same for hashCode().
                
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3350
>                 URL: https://issues.apache.org/jira/browse/HDFS-3350
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html].
 It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message