Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 19 Apr 2012 01:16:39 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <22186935.4164.1334798199997.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-891) DataNode no longer needs to check for
 dfs.network.script
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257130#comment-13257130 ] 

Hudson commented on HDFS-891:
-----------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2173 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2173/])
    HDFS-891. DataNode no longer needs to check for dfs.network.script. Contributed by Harsh J (Revision 1327762)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327762
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java

                
> DataNode no longer needs to check for dfs.network.script
> --------------------------------------------------------
>
>                 Key: HDFS-891
>                 URL: https://issues.apache.org/jira/browse/HDFS-891
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HDFS-891.patch, hdfs-891.txt
>
>
> Looking at the code for {{DataNode.instantiateDataNode())} , I see that it calls {{system.exit(-1)}} if it is not happy with the configuration
> {code}
>     if (conf.get("dfs.network.script") != null) {
>       LOG.error("This configuration for rack identification is not supported" +
>           " anymore. RackID resolution is handled by the NameNode.");
>       System.exit(-1);
>     }
> {code}
> This is excessive. It should throw an exception and let whoever called the method decide how to handle it. The {{DataNode.main()}} method will log the exception and exit with a -1 value, but other callers (such as anything using {{MiniDFSCluster}} will now see a meaningful message rather than some Junit "tests exited without completing" warning. 
> Easy to write a test for the correct behaviour: start a {{MiniDFSCluster}} with this configuration set, see what happens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira