Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 5 Apr 2012 17:40:23 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1737019162.18124.1333647623615.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <175019809.15364.1333589478670.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3202) NamespaceInfo PB translation drops
 build version
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247408#comment-13247408 ] 

Hudson commented on HDFS-3202:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2015 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2015/])
    HDFS-3202. NamespaceInfo PB translation drops build version. Contributed by Aaron T. Myers. (Revision 1309955)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309955
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NamespaceInfo.java

                
> NamespaceInfo PB translation drops build version
> ------------------------------------------------
>
>                 Key: HDFS-3202
>                 URL: https://issues.apache.org/jira/browse/HDFS-3202
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 2.0.0
>
>         Attachments: HDFS-3202.patch
>
>
> The PBHelper#convert(NamespaceInfoProto) function doesn't pass the build version from the NamespaceInfoProto to the created NamespaceInfo object. Instead, the NamespaceInfo constructor gets the build version using the static function Storage#getBuildVersion. DNs also use this static function to determine their own build version. This means that the check the DN does to compare its own build version to that of the NN always passes, regardless of what build version exists on the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira