Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 6 Apr 2012 22:38:15 +0000 (UTC)
From: "Eli Collins (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1189488699.307.1333751895471.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1513649360.25560.1333743562169.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3224) Bug in check for DN re-registration
 with different storage ID
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249008#comment-13249008 ] 

Eli Collins commented on HDFS-3224:
-----------------------------------

Btw here was the code before HDFS-3144. Host2NodesMap was using getHost which is the "name" w/o port

{code}
-    String host = node.getHost();
+    String ipAddr = node.getIpAddr();
{code}

and DatanodeManager was doing lookups with the "name"

{code}
-    DatanodeDescriptor nodeN = getDatanodeByHost(nodeReg.getName());
+    DatanodeDescriptor nodeN = getDatanodeByHost(nodeReg.getXferAddr());
{code}
                
> Bug in check for DN re-registration with different storage ID
> -------------------------------------------------------------
>
>                 Key: HDFS-3224
>                 URL: https://issues.apache.org/jira/browse/HDFS-3224
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eli Collins
>            Priority: Minor
>
> DatanodeManager#registerDatanode checks the host to node map using an IP:port key, however the map is keyed on IP, so this check will always fail. It's performing the check to determine if a DN with the same IP and storage ID has already registered, and if so to remove this DN from the map and indicate that eg it's no longer hosting these blocks. This bug has been here forever.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira