Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sun, 1 Apr 2012 22:12:28 +0000 (UTC)
From: "Eli Collins (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1158211848.3873.1333318348173.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <80010819.13733.1332633507427.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-3144) Refactor DatanodeID#getName by use
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3144:
------------------------------

    Attachment: hdfs-3144.txt

Updated per your feedback, only affected log messages and comments so I'll commit the new version attached. The earlier findbugs was due to the patch not applying. The test failures on the 2nd jenkins run (port in use and timeout) are due to me manually kicking this job on jenkins conflicting with another one.
                
> Refactor DatanodeID#getName by use
> ----------------------------------
>
>                 Key: HDFS-3144
>                 URL: https://issues.apache.org/jira/browse/HDFS-3144
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3144.txt, hdfs-3144.txt, hdfs-3144.txt, hdfs-3144.txt
>
>
> DatanodeID#getName, which returns a string containing the IP:xferPort of a Datanode, is used in a variety of contexts:
> # Putting the ID in a log message
> # Connecting to the DN for data transfer
> # Getting a string to use as a key (eg for comparison)
> # Using as a hostname, eg for excludes/includes, topology files
> Same for DatanodeID#getHost, which returns just the IP part, and sometimes we use it as a key, sometimes we tack on the IPC port, etc.
> Let's have a method for each use, eg toString can be used for #1, a new method (eg getDataXferAddr) for #2, a new method (eg getKey) for #3, new method (eg getHostID) for #4, etc. Aside from the code being more clear, we can change the value for particular uses, eg we can change the format in a log message without changing the address used that clients connect to the DN, or modify the address used for data transfer without changing the other uses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira