Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B135D9A7F for ; Tue, 24 Apr 2012 21:42:29 +0000 (UTC) Received: (qmail 46863 invoked by uid 500); 24 Apr 2012 21:42:29 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 46797 invoked by uid 500); 24 Apr 2012 21:42:29 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 46786 invoked by uid 99); 24 Apr 2012 21:42:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 21:42:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 21:42:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 4EDCC40D537 for ; Tue, 24 Apr 2012 21:42:08 +0000 (UTC) Date: Tue, 24 Apr 2012 21:42:08 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1074487432.397.1335303728324.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <954713493.735.1334969973404.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-3310) Make sure that we abort when no edit log directories are left MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261051#comment-13261051 ] Tsz Wo (Nicholas), SZE commented on HDFS-3310: ---------------------------------------------- I think should be replaced by exitIfNoStreams(). {code} + if (editStreams.isEmpty()) { + throw new IOException("no editlog streams"); + } {code} Patch looks good other then that. > Make sure that we abort when no edit log directories are left > ------------------------------------------------------------- > > Key: HDFS-3310 > URL: https://issues.apache.org/jira/browse/HDFS-3310 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.20.1 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-3310-b1.001.patch > > > We should make sure to abort when there are no edit log directories left to write to. It seems that there is at least one case that is slipping through the cracks right now in branch-1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira