hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3121) hdfs tests for HADOOP-8014
Date Wed, 04 Apr 2012 20:59:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246724#comment-13246724
] 

Suresh Srinivas commented on HDFS-3121:
---------------------------------------

Comments:
# Not very clear "THis test is test the fix.". Instead of describing running into serialization
problem etc. can you just describe what the test is. Also please move the description as class
level javadoc.
# minor: defaultBLockSize -> defaultBlockSize 
# Please ensure line lengths are with in 80 chars limit
# testGetDefaultBlockSize() indententation at "try" is not correct. I am also not clear about
the comment createFile... What has createFile got to do with the test?
# Please add a brief description of what the test is testing.
# Please consider: When expecting an exception in tests, you can move fail() within try clause,
after the method that you expect exception from. This avoids also return from catch blocks.


                
> hdfs tests for HADOOP-8014
> --------------------------
>
>                 Key: HDFS-3121
>                 URL: https://issues.apache.org/jira/browse/HDFS-3121
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.2, 0.23.3
>            Reporter: John George
>            Assignee: John George
>         Attachments: hdfs-3121.patch, hdfs-3121.patch, hdfs-3121.patch
>
>
> This JIRA is to write tests for viewing quota using viewfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message