hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3094) add -nonInteractive and -force option to namenode -format command
Date Wed, 11 Apr 2012 21:15:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251925#comment-13251925
] 

Todd Lipcon commented on HDFS-3094:
-----------------------------------

A few nits on the branch-1 patch:

{code}
+          System.err.println("Format aborted as dir "+ curDir +" exits.");
{code}
typo: "exists". I would also reformat as: "Format aborted: " + curDir + " exists."

the same typo ("exits" for "exists") is in one of the test cases

----
{code}
+      boolean isConfirmationNeeded, boolean isInterActive) throws IOException {
{code}
Should be {{isInteractive}} -- not capital 'A'

----
{code}
+      StartupOption.FORMAT.getName()  + "[" + StartupOption.FORCE.getName() +  
+      " ] ["+StartupOption.NONINTERACTIVE.getName()+"] | [" +
{code}
Formatting is off here. When I run it I see:
{code}
Usage: java NameNode [-format[-force ] [-nonInteractive] | [-upgrade] | [-rollback] | [-finalize]
| [-importCheckpoint]
{code}
should read:
{code}
Usage: java NameNode [-format [-force] [-nonInteractive]] | [-upgrade] | [-rollback] | [-finalize]
| [-importCheckpoint]
{code}

                
> add -nonInteractive and -force option to namenode -format command
> -----------------------------------------------------------------
>
>                 Key: HDFS-3094
>                 URL: https://issues.apache.org/jira/browse/HDFS-3094
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.24.0, 1.0.2
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>             Fix For: 2.0.0
>
>         Attachments: HDFS-3094.branch-1.0.patch, HDFS-3094.branch-1.0.patch, HDFS-3094.branch-1.0.patch,
HDFS-3094.branch-1.0.patch, HDFS-3094.branch-1.0.patch, HDFS-3094.branch-1.0.patch, HDFS-3094.branch-1.0.patch,
HDFS-3094.branch-1.0.patch, HDFS-3094.patch, HDFS-3094.patch, HDFS-3094.patch, HDFS-3094.patch,
HDFS-3094.patch, HDFS-3094.patch, HDFS-3094.patch
>
>
> Currently the bin/hadoop namenode -format prompts the user for a Y/N to setup the directories
in the local file system.
> -force : namenode formats the directories without prompting
> -nonInterActive : namenode format will return with an exit code of 1 if the dir exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message