hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3313) create a protocol for journal service synchronziation
Date Wed, 25 Apr 2012 00:56:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261190#comment-13261190
] 

Aaron T. Myers commented on HDFS-3313:
--------------------------------------

bq. As pointed out by Nicholas, the interface of getEditLogManifes() in JournalSyncProtocol
should be different(at least adding JournalInfo into the request) with the one in namenode
protocol.

Why couldn't you send the JournalInfo in all cases, both when calling getEditLogManifest on
the NN for checkpointing, and in the journal service?

Even with this slight difference, there's still a lot of duplicated code between the two,
and it seems a shame to implement two parallel, nearly identical methods in distinct protocols.
                
> create a protocol for journal service synchronziation  
> -------------------------------------------------------
>
>                 Key: HDFS-3313
>                 URL: https://issues.apache.org/jira/browse/HDFS-3313
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-3313.HDFS-3092.patch, HDFS-3313.HDFS-3092.patch
>
>
> This protocol is used to synchronize lagging journal service with active journal service
with complete finalized edit segments. Currently it supports one rpc call getEditLogManifest()
which lists finalized edit segments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message