hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3214) InterDatanodeProtocolServerSideTranslatorPB doesn't handle null response from initReplicaRecovery
Date Sun, 08 Apr 2012 09:54:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249511#comment-13249511
] 

Aaron T. Myers commented on HDFS-3214:
--------------------------------------

Patch looks pretty good to me, Todd. One small comment:

How about changing the numeric tags to be numerically increasing in InitReplicaRecoveryResponseProto
in InterDatanodeProtocol.proto? Considering there's so far been no release of HDFS with PB
support, there doesn't seem to be any reason to concern ourselves with maintaining PB backward
compatibility.

+1 once this is addressed, either by accepting the feedback or explaining your reasoning not
to.
                
> InterDatanodeProtocolServerSideTranslatorPB doesn't handle null response from initReplicaRecovery
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3214
>                 URL: https://issues.apache.org/jira/browse/HDFS-3214
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-3214.txt
>
>
> The initReplicaRecovery function may return null to indicate that the block doesn't exist
on the local node. However, the translator doesn't handle this case, which results in NPEs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message