hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3144) Refactor DatanodeID#getName by use
Date Sun, 01 Apr 2012 04:48:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243654#comment-13243654
] 

Hadoop QA commented on HDFS-3144:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12520811/hdfs-3144.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 96 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause tar ant target to fail.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed the unit tests build

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2146//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2146//console

This message is automatically generated.
                
> Refactor DatanodeID#getName by use
> ----------------------------------
>
>                 Key: HDFS-3144
>                 URL: https://issues.apache.org/jira/browse/HDFS-3144
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3144.txt, hdfs-3144.txt
>
>
> DatanodeID#getName, which returns a string containing the IP:xferPort of a Datanode,
is used in a variety of contexts:
> # Putting the ID in a log message
> # Connecting to the DN for data transfer
> # Getting a string to use as a key (eg for comparison)
> # Using as a hostname, eg for excludes/includes, topology files
> Same for DatanodeID#getHost, which returns just the IP part, and sometimes we use it
as a key, sometimes we tack on the IPC port, etc.
> Let's have a method for each use, eg toString can be used for #1, a new method (eg getDataXferAddr)
for #2, a new method (eg getKey) for #3, new method (eg getHostID) for #4, etc. Aside from
the code being more clear, we can change the value for particular uses, eg we can change the
format in a log message without changing the address used that clients connect to the DN,
or modify the address used for data transfer without changing the other uses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message