hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3313) create a protocol for journal service synchronziation
Date Tue, 24 Apr 2012 00:38:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260122#comment-13260122
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3313:
----------------------------------------------

Looks good.  Some comments:

- We should not change NameNodeProxies.  NN is not involved in journal synchronization.

- For the same reason, the principals in JournalSyncProtocolPB should not be Namenode.
{code}
+    serverPrincipal = DFSConfigKeys.DFS_NAMENODE_USER_NAME_KEY,
+    clientPrincipal = DFSConfigKeys.DFS_NAMENODE_USER_NAME_KEY)
{code}

- Use FSEditLog.getEditLogManifest(long fromTxId) instead of FileJournalManager and don't
change FileJournalManager.

- Why DN is related to JournalSyncProtocol?  Please check the comments.
{code}
+   * If you are adding/changing DN's interface then you need to change both this
{code}

- I think we should pass JournalInfo in getEditLogManifest(..) so that it could first verify
the version, namespace id, etc.

- Why the test is commented out?
{code}
-  @Test
+  //@Test
   public void testHttpServer() throws Exception {
{code}
                
> create a protocol for journal service synchronziation  
> -------------------------------------------------------
>
>                 Key: HDFS-3313
>                 URL: https://issues.apache.org/jira/browse/HDFS-3313
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-3313.HDFS-3092.patch
>
>
> This protocol is used to synchronize lagging journal service with active journal service
with complete finalized edit segments. Currently it supports one rpc call getEditLogManifest()
which lists finalized edit segments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message