hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3134) harden edit log loader against malformed or malicious input
Date Thu, 12 Apr 2012 02:18:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252144#comment-13252144
] 

Hadoop QA commented on HDFS-3134:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522365/HDFS-3134.003.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2255//console

This message is automatically generated.
                
> harden edit log loader against malformed or malicious input
> -----------------------------------------------------------
>
>                 Key: HDFS-3134
>                 URL: https://issues.apache.org/jira/browse/HDFS-3134
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-3134.001.patch, HDFS-3134.002.patch, HDFS-3134.003.patch
>
>
> Currently, the edit log loader does not handle bad or malicious input sensibly.
> We can often cause OutOfMemory exceptions, null pointer exceptions, or other unchecked
exceptions to be thrown by feeding the edit log loader bad input.  In some environments, an
out of memory error can cause the JVM process to be terminated.
> It's clear that we want these exceptions to be thrown as IOException instead of as unchecked
exceptions.  We also want to avoid out of memory situations.
> The main task here is to put a sensible upper limit on the lengths of arrays and strings
we allocate on command.  The other task is to try to avoid creating unchecked exceptions (by
dereferencing potentially-NULL pointers, for example).  Instead, we should verify ahead of
time and give a more sensible error message that reflects the problem with the input.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message