hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3230) Cleanup DatanodeID creation in the tests
Date Wed, 11 Apr 2012 17:11:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251749#comment-13251749
] 

Hadoop QA commented on HDFS-3230:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522217/hdfs-3230.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 10 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestDFSClientRetries

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2249//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2249//console

This message is automatically generated.
                
> Cleanup DatanodeID creation in the tests
> ----------------------------------------
>
>                 Key: HDFS-3230
>                 URL: https://issues.apache.org/jira/browse/HDFS-3230
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3230.txt
>
>
> A lot of tests create dummy DatanodeIDs for testing, often use bogus values when creating
the objects (eg hostname in the IP field), which they can get away with because the IDs aren't
actually used. Let's add a test utility method for creating a DatanodeID for testing and use
it throughout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message