hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3202) NamespaceInfo PB translation drops build version
Date Thu, 05 Apr 2012 02:59:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246968#comment-13246968
] 

Hadoop QA commented on HDFS-3202:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521443/HDFS-3202.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2191//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2191//console

This message is automatically generated.
                
> NamespaceInfo PB translation drops build version
> ------------------------------------------------
>
>                 Key: HDFS-3202
>                 URL: https://issues.apache.org/jira/browse/HDFS-3202
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-3202.patch
>
>
> The PBHelper#convert(NamespaceInfoProto) function doesn't pass the build version from
the NamespaceInfoProto to the created NamespaceInfo object. Instead, the NamespaceInfo constructor
gets the build version using the static function Storage#getBuildVersion. DNs also use this
static function to determine their own build version. This means that the check the DN does
to compare its own build version to that of the NN always passes, regardless of what build
version exists on the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message