hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3168) Clean up FSNamesystem and BlockManager
Date Wed, 04 Apr 2012 20:57:26 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246720#comment-13246720

Aaron T. Myers commented on HDFS-3168:

bq. Aaron, it is nothing to do with it. Any contributor could review code. It was a merging

I definitely didn't mean to imply that this particular compilation issue would have been caught
by a different reviewer. I'm confident I would not have caught this particular issue myself.

bq. I think this is not true. After a committer provided a patch and a non-committer reviewed
it, the same committer could commit the patch.

I think the bylaws are a little ambiguous on the subject. Per the bylaws:

*Code Change*
A change made to a codebase of the project and committed by a committer. This includes source
code, documentation, website content, etc. Lazy consensus of active committers, but with a
minimum of one +1. The code can be committed after the first +1, unless the code change represents
a merge from a branch, in which case three +1s are required.

This would seem to imply that a review by a non-committer contributor is non-binding. It does
not, however, clear up the issue of whether or not a committer can provide a +1 of their own

FWIW, my understanding is the same as Todd's on this subject.
> Clean up FSNamesystem and BlockManager
> --------------------------------------
>                 Key: HDFS-3168
>                 URL: https://issues.apache.org/jira/browse/HDFS-3168
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0, 0.23.3
>         Attachments: h3168_20120330.patch, h3168_20120402.patch, h3168_20120403.patch

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message