hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3275) Format command overwrites contents of non-empty shared edits dir if name dirs are empty without any prompting
Date Tue, 24 Apr 2012 18:57:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260822#comment-13260822
] 

Uma Maheswara Rao G commented on HDFS-3275:
-------------------------------------------

Looks you have missed one line in HDFS-3275_2.patch and HDFS-3275_3.patch


Below code from HDFS-3275_1.patch
{code}
+      assert dirUri.getScheme().equals(DEFAULT_SCHEME) : "formatting is not "
+          + "supported for" + dirUri;
+
+      File curDir = new File(dirUri.getPath());
       // Its alright for a dir not to exist, or to exist (properly accessible)
{code}

Please take care in next version of the patch.
                
> Format command overwrites contents of non-empty shared edits dir if name dirs are empty
without any prompting
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3275
>                 URL: https://issues.apache.org/jira/browse/HDFS-3275
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, name-node
>    Affects Versions: 2.0.0
>            Reporter: Vinithra Varadharajan
>            Assignee: amith
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3275.patch, HDFS-3275_1.patch, HDFS-3275_1.patch, HDFS-3275_2.patch,
HDFS-3275_2.patch, HDFS-3275_3.patch
>
>
> To reproduce:
> # Configure a NameNode with namedirs and a shared edits dir, all of which are empty.
> # Run hdfs namenode -format. Namedirs and shared edits dir gets populated.
> # Delete the contents of the namedirs. Leave the shared edits dir as is. Check the timestamps
of the shared edits dir contents.
> # Run format again. The namedirs as well as the shared edits dir get formatted. The shared
edits dir's contents have been replaced without any prompting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message