hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3280) DFSOutputStream.sync should not be synchronized
Date Sat, 14 Apr 2012 02:47:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253948#comment-13253948
] 

Hadoop QA commented on HDFS-3280:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522653/hdfs-3280.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2277//console

This message is automatically generated.
                
> DFSOutputStream.sync should not be synchronized
> -----------------------------------------------
>
>                 Key: HDFS-3280
>                 URL: https://issues.apache.org/jira/browse/HDFS-3280
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-3280.txt
>
>
> HDFS-895 added an optimization to make hflush() much faster by unsynchronizing it. But,
we forgot to un-synchronize the deprecated {{sync()}} wrapper method. This makes the HBase
WAL really slow on 0.23+ since it doesn't take advantage of HDFS-895 anymore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message