hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3204) Minor modification to JournalProtocol.proto to make it generic
Date Thu, 05 Apr 2012 22:24:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247772#comment-13247772
] 

Hadoop QA commented on HDFS-3204:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521574/HDFS-3204.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2202//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2202//console

This message is automatically generated.
                
> Minor modification to JournalProtocol.proto to make it generic
> --------------------------------------------------------------
>
>                 Key: HDFS-3204
>                 URL: https://issues.apache.org/jira/browse/HDFS-3204
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Suresh Srinivas
>         Attachments: HDFS-3204.txt, HDFS-3204.txt, HDFS-3204.txt
>
>
> JournalProtocol.proto uses NamenodeRegistration in methods such as journal() for identifying
the source. I want to make it generic so that the method can be called with journal information
to identify the journal. I plan to use the protocol also for sync purposes, where the source
of the journal can be some thing other than namenode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message