hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3120) Enable hsync and hflush by default
Date Tue, 03 Apr 2012 00:15:26 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244870#comment-13244870

Hadoop QA commented on HDFS-3120:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 51 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these unit tests:

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2164//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2164//console

This message is automatically generated.
> Enable hsync and hflush by default
> ----------------------------------
>                 Key: HDFS-3120
>                 URL: https://issues.apache.org/jira/browse/HDFS-3120
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3120.txt, hdfs-3120.txt
> The work on branch-20-append was to support *sync*, for durable HBase WALs, not *append*.
The branch-20-append implementation is known to be buggy. There's been confusion about this,
we often answer queries on the list [like this|http://search-hadoop.com/m/wfed01VOIJ5]. Unfortunately,
the way to enable correct sync on branch-1 for HBase is to set dfs.support.append to true
in your config, which has the side effect of enabling append (which we don't want to do).
> Let's add a new *dfs.support.sync* option that enables working sync (which is basically
the current dfs.support.append flag modulo one place where it's not referring to sync). For
compatibility, if dfs.support.append is set, dfs.support.sync will be set as well. This way
someone can enable sync for HBase and still keep the current behavior that if dfs.support.append
is not set then an append operation will result in an IOE indicating append is not supported.
We should do this on trunk as well, as there's no reason to conflate hsync and append with
a single config even if append works.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message