hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3213) JournalDaemon (server) should persist the cluster id and nsid in the storage directory
Date Wed, 11 Apr 2012 02:04:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251249#comment-13251249
] 

Tsz Wo (Nicholas), SZE commented on HDFS-3213:
----------------------------------------------

- In JournalService.fence(..), should the setupStorage(..) call be after verifyFence(..) and
verify(..)?
- JournalService.conf is only used in setupStorage(..).  Instead of adding it as a field,
it is better to replace it with NNStorage since the conf values are fixed.  We don't have
to create the objects in setupStorage(..).
- Need to add Assert.fail() after fence(..) in the new tests.  Otherwise, the test will pass
even if fence(..) does not throw exceptions.  I think it is better to print out the exception
in the catch-blocks instead of leaving them empty.

In addition, we need to think about how to synchronize the methods in JournalService.  Do
you want to do it here or in a separated issue?
                
> JournalDaemon (server) should persist the cluster id and nsid in the storage directory
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3213
>                 URL: https://issues.apache.org/jira/browse/HDFS-3213
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>         Attachments: hdfs-3213-1.patch, hdfs-3213.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message