hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3084) FenceMethod.tryFence() and ShellCommandFencer should pass namenodeId as well as host:port
Date Wed, 04 Apr 2012 09:58:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246143#comment-13246143
] 

Hadoop QA commented on HDFS-3084:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521282/hdfs-3084.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2182//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2182//console

This message is automatically generated.
                
> FenceMethod.tryFence() and ShellCommandFencer should pass namenodeId as well as host:port
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-3084
>                 URL: https://issues.apache.org/jira/browse/HDFS-3084
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ha
>    Affects Versions: 0.24.0, 0.23.3
>            Reporter: Philip Zeyliger
>            Assignee: Todd Lipcon
>         Attachments: hdfs-3084.txt
>
>
> The FenceMethod interface passes along the host:port of the NN that needs to be fenced.
 That's great for the common case.  However, it's likely necessary to have extra configuration
parameters for fencing, and these are typically keyed off the nameserviceId.namenodeId (if,
for nothing else, consistency with all the other parameters that are keyed off of namespaceId.namenodeId).
 Obviously this can be backed out from the host:port, but it's inconvenient, and requires
iterating through all the configs.
> The shell interface exhibits the same issue: host:port is great for most fencers, but
if you need extra configs (like the host:port of the power supply unit), those are harder
to pipe through without the namenodeId.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message