hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-891) DataNode no longer needs to check for dfs.network.script
Date Wed, 18 Apr 2012 22:26:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257032#comment-13257032

Hadoop QA commented on HDFS-891:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2301//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2301//console

This message is automatically generated.
> DataNode no longer needs to check for dfs.network.script
> --------------------------------------------------------
>                 Key: HDFS-891
>                 URL: https://issues.apache.org/jira/browse/HDFS-891
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HDFS-891.patch, hdfs-891.txt
> Looking at the code for {{DataNode.instantiateDataNode())} , I see that it calls {{system.exit(-1)}}
if it is not happy with the configuration
> {code}
>     if (conf.get("dfs.network.script") != null) {
>       LOG.error("This configuration for rack identification is not supported" +
>           " anymore. RackID resolution is handled by the NameNode.");
>       System.exit(-1);
>     }
> {code}
> This is excessive. It should throw an exception and let whoever called the method decide
how to handle it. The {{DataNode.main()}} method will log the exception and exit with a -1
value, but other callers (such as anything using {{MiniDFSCluster}} will now see a meaningful
message rather than some Junit "tests exited without completing" warning. 
> Easy to write a test for the correct behaviour: start a {{MiniDFSCluster}} with this
configuration set, see what happens.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message